<html>
<head><meta charset="utf-8"><title>miri-rustc-tests · t-compiler/const-eval · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/146212-t-compiler/const-eval/index.html">t-compiler/const-eval</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/146212-t-compiler/const-eval/topic/miri-rustc-tests.html">miri-rustc-tests</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="136405102"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/146212-t-compiler/const-eval/topic/miri-rustc-tests/near/136405102" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> RalfJ <a href="https://rust-lang.github.io/zulip_archive/stream/146212-t-compiler/const-eval/topic/miri-rustc-tests.html#136405102">(Oct 24 2018 at 12:22)</a>:</h4>
<p><span class="user-mention" data-user-id="124288">@Oli</span> any idea why the miri-rustc-tests binary passes <code>-Zmir-opt-level=3</code>?</p>



<a name="136414406"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/146212-t-compiler/const-eval/topic/miri-rustc-tests/near/136414406" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> oli <a href="https://rust-lang.github.io/zulip_archive/stream/146212-t-compiler/const-eval/topic/miri-rustc-tests.html#136414406">(Oct 24 2018 at 14:48)</a>:</h4>
<p>nope, have you tried git blaming the line?</p>



<a name="136415363"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/146212-t-compiler/const-eval/topic/miri-rustc-tests/near/136415363" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> RalfJ <a href="https://rust-lang.github.io/zulip_archive/stream/146212-t-compiler/const-eval/topic/miri-rustc-tests.html#136415363">(Oct 24 2018 at 15:01)</a>:</h4>
<p>not yet</p>



<a name="136415433"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/146212-t-compiler/const-eval/topic/miri-rustc-tests/near/136415433" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> RalfJ <a href="https://rust-lang.github.io/zulip_archive/stream/146212-t-compiler/const-eval/topic/miri-rustc-tests.html#136415433">(Oct 24 2018 at 15:02)</a>:</h4>
<p><span class="user-mention" data-user-id="124288">@Oli</span> here it is: <a href="https://github.com/solson/miri/commit/8b81f5430f5f95f19e2c3d452971ef3380537a49#diff-5f266410c072c63b36718d107e25c370R152" target="_blank" title="https://github.com/solson/miri/commit/8b81f5430f5f95f19e2c3d452971ef3380537a49#diff-5f266410c072c63b36718d107e25c370R152">https://github.com/solson/miri/commit/8b81f5430f5f95f19e2c3d452971ef3380537a49#diff-5f266410c072c63b36718d107e25c370R152</a></p>



<a name="136415487"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/146212-t-compiler/const-eval/topic/miri-rustc-tests/near/136415487" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> oli <a href="https://rust-lang.github.io/zulip_archive/stream/146212-t-compiler/const-eval/topic/miri-rustc-tests.html#136415487">(Oct 24 2018 at 15:03)</a>:</h4>
<p>oh. right. a few PRs before that we were manually registering the optimization passes</p>



<a name="136415492"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/146212-t-compiler/const-eval/topic/miri-rustc-tests/near/136415492" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> oli <a href="https://rust-lang.github.io/zulip_archive/stream/146212-t-compiler/const-eval/topic/miri-rustc-tests.html#136415492">(Oct 24 2018 at 15:03)</a>:</h4>
<p>which caused us to diverge from the rustc passes</p>



<a name="136415541"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/146212-t-compiler/const-eval/topic/miri-rustc-tests/near/136415541" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> oli <a href="https://rust-lang.github.io/zulip_archive/stream/146212-t-compiler/const-eval/topic/miri-rustc-tests.html#136415541">(Oct 24 2018 at 15:04)</a>:</h4>
<p>so this change was to not change behavior</p>



<a name="136415861"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/146212-t-compiler/const-eval/topic/miri-rustc-tests/near/136415861" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> RalfJ <a href="https://rust-lang.github.io/zulip_archive/stream/146212-t-compiler/const-eval/topic/miri-rustc-tests.html#136415861">(Oct 24 2018 at 15:10)</a>:</h4>
<p>seems odd though, to make level 3 the default</p>



<a name="136415915"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/146212-t-compiler/const-eval/topic/miri-rustc-tests/near/136415915" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> RalfJ <a href="https://rust-lang.github.io/zulip_archive/stream/146212-t-compiler/const-eval/topic/miri-rustc-tests.html#136415915">(Oct 24 2018 at 15:10)</a>:</h4>
<p>I think level 0 should be default, and it actually is in my latest miri branch</p>



<a name="136415924"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/146212-t-compiler/const-eval/topic/miri-rustc-tests/near/136415924" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> RalfJ <a href="https://rust-lang.github.io/zulip_archive/stream/146212-t-compiler/const-eval/topic/miri-rustc-tests.html#136415924">(Oct 24 2018 at 15:10)</a>:</h4>
<p>and in making that consistent I realized this oddity in the rustc test runner</p>



<a name="136416217"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/146212-t-compiler/const-eval/topic/miri-rustc-tests/near/136416217" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> RalfJ <a href="https://rust-lang.github.io/zulip_archive/stream/146212-t-compiler/const-eval/topic/miri-rustc-tests.html#136416217">(Oct 24 2018 at 15:15)</a>:</h4>
<p>I'd prefer to remove it, make things more consistent?</p>



<a name="136416514"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/146212-t-compiler/const-eval/topic/miri-rustc-tests/near/136416514" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> oli <a href="https://rust-lang.github.io/zulip_archive/stream/146212-t-compiler/const-eval/topic/miri-rustc-tests.html#136416514">(Oct 24 2018 at 15:19)</a>:</h4>
<p>seems fine</p>



<a name="136416944"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/146212-t-compiler/const-eval/topic/miri-rustc-tests/near/136416944" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> RalfJ <a href="https://rust-lang.github.io/zulip_archive/stream/146212-t-compiler/const-eval/topic/miri-rustc-tests.html#136416944">(Oct 24 2018 at 15:26)</a>:</h4>
<p>done</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>